----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70716/#review215496 -----------------------------------------------------------
Patch looks great! Reviews applied: [70705, 70706, 70707, 70713, 70714, 70715, 70716] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 24, 2019, 5:30 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70716/ > ----------------------------------------------------------- > > (Updated May 24, 2019, 5:30 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, resource quota acts as both guarantees and limits. > This patch adds a field `quotaLimits` in the role struct. > This paves the way for enforcing guarantees and limits > separately in the allocator. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 7e4f30d16010a777ff29ba35366ae80ff2631322 > src/master/allocator/mesos/hierarchical.cpp > ccca391fbf73d9aa9c31f7552e39fb78c242e242 > > > Diff: https://reviews.apache.org/r/70716/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
