> On May 24, 2019, 3:59 p.m., Benjamin Mahler wrote: > > src/tests/master/update_framework_tests.cpp > > Lines 417 (patched) > > <https://reviews.apache.org/r/70534/diff/7/?file=2146074#file2146074line417> > > > > Can you explain what this is testing?
Split this test into two, tried to come up with better names for them and added a comment to each - I hope now it is more readable. > On May 24, 2019, 3:59 p.m., Benjamin Mahler wrote: > > src/tests/master/update_framework_tests.cpp > > Lines 429-430 (patched) > > <https://reviews.apache.org/r/70534/diff/7/?file=2146074#file2146074line429> > > > > Why is this customization needed? Not needed at all - removed it. Also tried to remove other remaining customization wherever possible. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215500 ----------------------------------------------------------- On May 28, 2019, 5:36 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70534/ > ----------------------------------------------------------- > > (Updated May 28, 2019, 5:36 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7258 > https://issues.apache.org/jira/browse/MESOS-7258 > > > Repository: mesos > > > Description > ------- > > Added tests for the V1 UPDATE_FRAMEWORK call. > > > Diffs > ----- > > src/Makefile.am 5f97523fbe2d80733fbdcc7706f2761f5a071f9f > src/tests/CMakeLists.txt e6b1d8a097246f0921467d7f778034d6754fcff6 > src/tests/master/update_framework_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70534/diff/8/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
