----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70782/#review215715 -----------------------------------------------------------
Patch looks great! Reviews applied: [70778, 70782] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 5, 2019, 11:47 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70782/ > ----------------------------------------------------------- > > (Updated June 5, 2019, 11:47 p.m.) > > > Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Greg Mann. > > > Bugs: MESOS-9808 > https://issues.apache.org/jira/browse/MESOS-9808 > > > Repository: mesos > > > Description > ------- > > Added a non-deterministic test for MESOS-9808. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/process_tests.cpp > 05dc5ec2fdc74a989689e4378bef775bcf2b7a87 > > > Diff: https://reviews.apache.org/r/70782/diff/2/ > > > Testing > ------- > > Without any of two fixes from https://reviews.apache.org/r/70778/ - deadlocks > 100 out of 100 times on the hardware I used. > Without the first fix the deadlock is due to the same reason as initially > observed in in MESOS-9808. > > > With both fixes applied, one run takes around 400 ms on a release build. No > deadlock observed in 1000 runs. > > > Thanks, > > Andrei Sekretenko > >
