----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70786/#review215731 -----------------------------------------------------------
Fix it, then Ship it! src/Makefile.am Lines 650 (patched) <https://reviews.apache.org/r/70786/#comment302547> Don't you need to change the CMake build? src/common/resources_utils.hpp Lines 242-244 (original), 241-243 (patched) <https://reviews.apache.org/r/70786/#comment302548> Wrap both consistently? - Benjamin Mahler On June 5, 2019, 4:17 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70786/ > ----------------------------------------------------------- > > (Updated June 5, 2019, 4:17 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Some public facing classes such as `Resources` already depends > on `ResourceQuantities` and more are coming. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > f1868387b28ea1d303cd3ed0176e32d66debd4c1 > include/mesos/resources.hpp 609ca61a0ffa80a7b10e6a3ebb0caa15966c3371 > include/mesos/v1/resources.hpp 8afccbe2673cc892667d74ea982d69a3ef122066 > src/Makefile.am 5f97523fbe2d80733fbdcc7706f2761f5a071f9f > src/common/resource_quantities.hpp 538256bed96e72b4b61daa3052a111f59e252284 > src/common/resource_quantities.cpp f79b6786ccc93fff32447c9f9c3a0801500e7527 > src/common/resources.cpp 543820de435eb4869fbb93534fa00c58a9c5dfdd > src/common/resources_utils.hpp 9b78ca231fe24aa88edfc3c14c39563737c5856f > src/common/resources_utils.cpp 58fdb317809dd2b4dbc865e7d3eae5ebcdf5f174 > src/master/allocator/mesos/hierarchical.cpp > aa4c43882d0befb2100c92f383e87ab637fa4c7e > src/master/allocator/sorter/drf/sorter.hpp > 91a9d668b87079158f7072780dc86bb08865166e > src/master/allocator/sorter/random/sorter.hpp > 55e22d7705f163fe47d5aa47416ee0714c5a87c0 > src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b > src/master/quota.cpp bad19a2b8c1f8e4e044b0dc31374cbd34673ef1d > src/master/validation.cpp 65af1a773ed98651daa1aed2ee44aff15f2fe724 > src/tests/hierarchical_allocator_benchmarks.cpp > 797cf7eab8e31124db3046019684aae20f78f781 > src/tests/hierarchical_allocator_tests.cpp > 7221a642a8dda1c7b8ed5ebe7f9b840b5e949e88 > src/tests/resource_quantities_tests.cpp > f018c8a10a169d196a36c441929f477df6ef0df1 > src/tests/resources_tests.cpp bbac85180214a8197c42395990484cfdd4ee8a38 > src/v1/resources.cpp 7d6113fa8b45aedbd7135d29083983ae7641a9da > > > Diff: https://reviews.apache.org/r/70786/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
