----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215793 -----------------------------------------------------------
src/slave/containerizer/mesos/launch.cpp Line 508 (original), 509 (patched) <https://reviews.apache.org/r/70811/#comment302672> I am 100% with BenB here - silently ignoring seems a ticket for hard to explain / debug problems. Let's please return an `Error` suggesting that this setting was not supported on macOS instead. - Till Toenshoff On June 7, 2019, 5:21 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70811/ > ----------------------------------------------------------- > > (Updated June 7, 2019, 5:21 p.m.) > > > Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and > Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > This patch adds missing switch case to fix compilation error introduced > in `bc5a57122635`. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp > a69a68823842171bb15ddf34a504e5ce4af232b0 > > > Diff: https://reviews.apache.org/r/70811/diff/1/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >