----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70800/#review215814 -----------------------------------------------------------
Fix it, then Ship it! src/master/quota_handler.cpp Lines 27 (patched) <https://reviews.apache.org/r/70800/#comment302711> no newline here but newline between authorizer and quota includes? src/master/quota_handler.cpp Lines 76-78 (original), 77-79 (patched) <https://reviews.apache.org/r/70800/#comment302712> Shall we clarify here that it's guarantees as well? src/master/quota_handler.cpp Lines 120-121 (original), 124-126 (patched) <https://reviews.apache.org/r/70800/#comment302713> ``` // Check whether the tree satisfies: // // parent guarantees >= sum(children guarantees) // // TODO(mzhu): Add limit check. ``` src/master/quota_handler.cpp Lines 145-147 (patched) <https://reviews.apache.org/r/70800/#comment302714> This TODO seems to belong somewhere else (I assume this is talking about a caller? or is this talking about the checks within the quota tree code?) src/master/quota_handler.cpp Line 173 (original), 182 (patched) <https://reviews.apache.org/r/70800/#comment302715> space after guarantees also, not yours but one is using parens and the other is not? - Benjamin Mahler On June 7, 2019, 5:22 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70800/ > ----------------------------------------------------------- > > (Updated June 7, 2019, 5:22 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9807 > https://issues.apache.org/jira/browse/MESOS-9807 > > > Repository: mesos > > > Description > ------- > > This refactor makes the `QuotaTree` to use the new > quota wrapper struct. > > Also refactor the check to reflect that it is currently > only checking guarantees. > > > Diffs > ----- > > src/master/quota_handler.cpp 21176dd8a76fda621f0f98878efa67ecf862368c > > > Diff: https://reviews.apache.org/r/70800/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
