----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70839/#review215841 -----------------------------------------------------------
src/common/protobuf_utils.cpp Line 1133 (original), 1133 (patched) <https://reviews.apache.org/r/70839/#comment302778> This would have auto-upgraded would we have used a protobuf `MessageDifferencer`. What do you think about introducing its use now? - Benjamin Bannier On June 12, 2019, 10:10 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70839/ > ----------------------------------------------------------- > > (Updated June 12, 2019, 10:10 a.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and > Joseph Wu. > > > Bugs: MESOS-9818 > https://issues.apache.org/jira/browse/MESOS-9818 > > > Repository: mesos > > > Description > ------- > > Added agent capability for agent draining. > > > Diffs > ----- > > include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9 > include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e > src/common/protobuf_utils.hpp ecaf8ea36c486b859870fe53e834e0844e317182 > src/common/protobuf_utils.cpp 9ff0cf59c658c7c6a3a439a77aff13aff3c20fe5 > src/slave/constants.cpp 4c29b00f25aee5475051a4eb6d0d587ca2b7b6d4 > src/slave/flags.cpp e23061ad929c8e3c24806f52c95f82766e3d1911 > src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e > src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271 > > > Diff: https://reviews.apache.org/r/70839/diff/1/ > > > Testing > ------- > > Testing details at the end of this chain. > > > Thanks, > > Greg Mann > >
