----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70803/#review215850 -----------------------------------------------------------
Ship it! commit description says "deprecated" but means "removed"? include/mesos/allocator/allocator.hpp Lines 466 (patched) <https://reviews.apache.org/r/70803/#comment302787> and no limits src/master/allocator/mesos/hierarchical.cpp Lines 1475 (patched) <https://reviews.apache.org/r/70803/#comment302788> single quote the role? src/tests/master_quota_tests.cpp Lines 502-503 (patched) <https://reviews.apache.org/r/70803/#comment302789> Maybe just: ``` EXPECT_EQ(master::DEFAULT_QUOTA, *receivedQuotaRequest); ``` Or can we replace the `_` above with the expected quota? Ditto for the others - Benjamin Mahler On June 7, 2019, 5:25 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70803/ > ----------------------------------------------------------- > > (Updated June 7, 2019, 5:25 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9820 > https://issues.apache.org/jira/browse/MESOS-9820 > > > Repository: mesos > > > Description > ------- > > This call updates a role's quota guarantees and limits. > All roles have a default quota defined as `DEFAULT_QUOTA`. > Currently, it is no guarantees and limits. Thus to "remove" > a quota, one should simply update the quota to be > `DEFAULT_QUOTA`. > > Master `setQuota` and `removeQuota` calls into the allocator > are replaced with the `updateQuota`. > > `setQuota` and `removeQuota` calls are now only used in the tests. > They will be deprecated once those tests are refactored. > > Also fixed affected tests. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > eafcdfdab7f0fc9570e65db15274b52495aa6de3 > src/master/allocator/mesos/allocator.hpp > 2d83f382eed9d9dca218adf84bc03883f7486349 > src/master/allocator/mesos/hierarchical.hpp > 1a3329d0e50ad2adb6aeadcd5d315eb572a85704 > src/master/allocator/mesos/hierarchical.cpp > ad0bcca90dcce4c9e8384293181c4f4af3d274aa > src/master/quota_handler.cpp 21176dd8a76fda621f0f98878efa67ecf862368c > src/tests/allocator.hpp 0718bef4de39a82dbcadebb9967d2ff1cceb1cae > src/tests/master_quota_tests.cpp 146b9779df307f641d415f28f70c2fb03cb870b5 > > > Diff: https://reviews.apache.org/r/70803/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
