----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70879/ -----------------------------------------------------------
Review request for mesos, Armand Grillet and Meng Zhu. Repository: mesos Description ------- The Roles tab currently uses an inconsistent mix of '0', '0 B' and '-' for displaying the allocation, guarantee, and limit. Since it's easier to scan the table for non-empty entries when '-' is used, this updates the every empty case to use '-'. We may also want to consider using the empty string '' in the future, as that may help make the table even easier to scan visually than '-'. Diffs ----- src/webui/app/roles/roles.html c8ac1ef6cdfbc6d6a3d5c2e619896e8656a9badf Diff: https://reviews.apache.org/r/70879/diff/1/ Testing ------- Ran manually, see screenshot. File Attachments ---------------- post-changes https://reviews.apache.org/media/uploaded/files/2019/06/18/ab42cf05-9252-4eed-a765-4126c5ed23a4__Screen_Shot_2019-06-18_at_4.16.49_PM.png pre-changes https://reviews.apache.org/media/uploaded/files/2019/06/18/29122c1d-dae3-4d4c-8a52-062971d603c0__Screen_Shot_2019-06-18_at_4.21.27_PM.png Thanks, Benjamin Mahler
