----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70810/#review215997 -----------------------------------------------------------
Fix it, then Ship it! Great work. I have added a few minor comments and would appreciate consideration. Thanks! docs/ssl.md Lines 24 (patched) <https://reviews.apache.org/r/70810/#comment302925> Should we write TLS instead of SSL in new text sections? docs/ssl.md Lines 30 (patched) <https://reviews.apache.org/r/70810/#comment302926> ... provides external clients ... with the ability ... docs/ssl.md Lines 33 (patched) <https://reviews.apache.org/r/70810/#comment302927> ensures docs/ssl.md Lines 37 (patched) <https://reviews.apache.org/r/70810/#comment302928> maybe WARNING instead of NOTE docs/ssl.md Lines 47 (patched) <https://reviews.apache.org/r/70810/#comment302929> if `LIBPROCESS_SSL_ENABLE_DOWNGRADE` is set to `false` docs/ssl.md Lines 88 (patched) <https://reviews.apache.org/r/70810/#comment302923> Let's make clear that the server is _required_ to present a certificate. docs/ssl.md Lines 90 (patched) <https://reviews.apache.org/r/70810/#comment302922> Let's define "and contain the correct hostname", let's refer to the available algorithms. docs/ssl.md Lines 99 (patched) <https://reviews.apache.org/r/70810/#comment302924> Let's maybe clarify "including tools hitting endpoints" (HTTP clients hitting HTTP endpoints?) - Jan-Philip Gehrcke On June 19, 2019, 2:31 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70810/ > ----------------------------------------------------------- > > (Updated June 19, 2019, 2:31 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff. > > > Bugs: MESOS-9791 > https://issues.apache.org/jira/browse/MESOS-9791 > > > Repository: mesos > > > Description > ------- > > Updated SSL docs to reflect the changes introduced in the previous commit and > added a section with suggested runtime configuration intended for operators. > > > Diffs > ----- > > docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c > > > Diff: https://reviews.apache.org/r/70810/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
