> On June 21, 2019, 8:26 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > > Lines 400 (patched) > > <https://reviews.apache.org/r/70844/diff/1/?file=2149226#file2149226line400> > > > > if the shmPath not exists, should we log a warning?
No, because shmPath not exists is a normal case for the containers which share its parent's shm. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70844/#review216029 ----------------------------------------------------------- On June 12, 2019, 10:36 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70844/ > ----------------------------------------------------------- > > (Updated June 12, 2019, 10:36 p.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9788 > https://issues.apache.org/jira/browse/MESOS-9788 > > > Repository: mesos > > > Description > ------- > > Implemented `cleanup` method of the `namespaces/ipc` isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp > 32c888309ca536d944e4d73641aed214805ccce2 > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > 6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7 > > > Diff: https://reviews.apache.org/r/70844/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
