> On June 21, 2019, 1:06 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Line 96 (original), 96 (patched) > > <https://reviews.apache.org/r/70748/diff/4/?file=2151330#file2151330line96> > > > > Additional to the updates above, we also need to call this out in the > > CHANGELOG. Can you please include that in this chain?
I added the `CHANGELOG` changes in a new review https://reviews.apache.org/r/70921/ - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/#review216009 ----------------------------------------------------------- On June 19, 2019, 2:28 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70748/ > ----------------------------------------------------------- > > (Updated June 19, 2019, 2:28 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jan-Philip Gehrcke, Joseph Wu, > and Till Toenshoff. > > > Bugs: MESOS-9810 > https://issues.apache.org/jira/browse/MESOS-9810 > > > Repository: mesos > > > Description > ------- > > This commit slightly updates the semants of the > `LIBPROCESS_SSL_VERIFY_CERT` and `LIBPROCESS_SSL_REQUIRE_CERT` > environment variables. The former now only applies to connections > in client mode and the latter now only applies to connections in > server mode. > > In particular, in TLS server mode we now *only* verify client > certificates when `LIBPROCESS_SSL_REQUIRE_CERT` is set to `true`, > regardless of the value of `LIBPROCESS_SSL_VERIFY_CERT`. > > In addition, when in SSL client mode and `LIBPROCESS_SSL_VERIFY_CERT` > has been set to `true`, enforce that the server actually presents a > certificate that can be verified. Note that this is expected to be > not a behavioural change in practice, since the TLS specification > already states that a server MUST always send a certificate unless an > anonymous cipher is used, and most TLS ciphersuites are configured to > exclude anonymous ciphers. > > > Diffs > ----- > > 3rdparty/libprocess/src/openssl.hpp > 17bec246e516261f8d772f1647c17f092fae82d1 > 3rdparty/libprocess/src/openssl.cpp > e7dbd67913fa8e7fbbf60dee428e7e38895f86ce > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > 29a1bf71c1df9d80370455a6269ecea0ec4193b0 > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 6b8496aeeed79ae1bd39d7013f4f403b248fdd4c > > > Diff: https://reviews.apache.org/r/70748/diff/4/ > > > Testing > ------- > > So far, mostly manual testing. > > > Thanks, > > Benno Evers > >
