> On June 21, 2019, 8:23 a.m., James DeFelice wrote: > > include/mesos/master/master.proto > > Lines 93 (patched) > > <https://reviews.apache.org/r/70911/diff/4/?file=2151618#file2151618line93> > > > > are these new APIs experimental? if so, they should be labeled as such
By the time the entire chain of agent draining work is done, these APIs won't be experimental. If we land this patch independently, then yes, we'll need to mark them experimental. > On June 21, 2019, 8:23 a.m., James DeFelice wrote: > > include/mesos/v1/master/master.proto > > Lines 19 (patched) > > <https://reviews.apache.org/r/70911/diff/4/?file=2151619#file2151619line19> > > > > why this note? i thought proto3 also had support for well-known types. Once we switch to proto3, we won't need to explicitly include a proto3 type. Since we're on proto2, this line pulls in a proto3 object, which otherwise isn't present by default. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70911/#review216046 ----------------------------------------------------------- On June 21, 2019, 6:10 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70911/ > ----------------------------------------------------------- > > (Updated June 21, 2019, 6:10 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and > Vinod Kone. > > > Bugs: MESOS-9814 > https://issues.apache.org/jira/browse/MESOS-9814 > > > Repository: mesos > > > Description > ------- > > This adds three master calls: > * DRAIN_AGENT > * DEACTIVATE_AGENT > * REACTIVATE_AGENT > > DRAIN_AGENT starts automated draining of tasks on the specified agent. > When marked for draining, the agent's resources will not be offered > and all the agent's tasks will be gracefully killed. > > DEACTIVATE_AGENT stops offers for a specific agent. This can be used > for manual draining of tasks, but is not limited to draining. > For example, tn operator could deactivate an agent prior to > reserving resources. > > REACTIVATE_AGENT restarts offers for a specific agent, that had been > drained or deactivated previously. > > > Diffs > ----- > > include/mesos/master/master.proto 4a653ce59268a47d69362d0e2a3d5eb867ca6fa9 > include/mesos/v1/master/master.proto > d4dd3fcb0abc947097a5a281c4082ccf04db8614 > src/internal/devolve.hpp fefe86e450fa5083b9ff50e92f4594ffb30a54c8 > src/internal/devolve.cpp 1d300b49d5cc3de4b8ed409902eb881c7afc07ea > src/master/http.cpp 3cd7df228adb54a963821c23b4d1c26d33622ee7 > src/master/master.hpp 7acaa8264eb7a37e17394bc4940971f872ab2de3 > src/master/validation.cpp af2d04a46750e5d42e7d92c70ce685e64d646a3b > > > Diff: https://reviews.apache.org/r/70911/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
