----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70910/#review216052 -----------------------------------------------------------
Ship it! - Greg Mann On June 20, 2019, 9 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70910/ > ----------------------------------------------------------- > > (Updated June 20, 2019, 9 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and > Vinod Kone. > > > Bugs: MESOS-9814 > https://issues.apache.org/jira/browse/MESOS-9814 > > > Repository: mesos > > > Description > ------- > > This adds three ACLs for the three endpoints added as part of the > agent draining feature: > * DRAIN_AGENT > * DEACTIVATE_AGENT > * REACTIVATE_AGENT > > All three ACLs are coarse-grained; a principal is either allowed to > perform the action, or unauthorized. However, there is scope to > restrict the action to particular subsets of agents in future. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > 78acfe622603f3697150c81bcf8c7a31deed9699 > include/mesos/authorizer/authorizer.proto > ad40d3add9db7540c328ebcf3aae771ff966528e > src/authorizer/local/authorizer.cpp > b89010d09ef3ee564e7659c0cfe335281656e1cd > src/tests/authorization_tests.cpp 7bb0bd831c7c71558cc981ce00ab399e0034bbdf > src/tests/master_authorization_tests.cpp > 7d406950d113c40637054f2d0f5edd2b81f7410a > > > Diff: https://reviews.apache.org/r/70910/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
