> On June 24, 2019, 4:50 p.m., Benjamin Mahler wrote: > > The commit summary "Refactored raw duration into const variable." could be > > clearer, how about: > > > > ``` > > Moved an inline duration for slow DNS logging into a const variable. > > ``` > > > > With this I can immediately understand the change from the commit summary, > > I wouldn't need to read the description / diff to get a sense of the change.
Sounds good, updated. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70933/#review216096 ----------------------------------------------------------- On June 24, 2019, 12:22 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70933/ > ----------------------------------------------------------- > > (Updated June 24, 2019, 12:22 p.m.) > > > Review request for mesos, Benjamin Mahler and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Moved the 100ms threshold that was used for printing warning > messages about slow reverse DNS lookups into a named variable. > > > Diffs > ----- > > 3rdparty/libprocess/src/openssl.cpp > e7dbd67913fa8e7fbbf60dee428e7e38895f86ce > > > Diff: https://reviews.apache.org/r/70933/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
