----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70945/#review216127 -----------------------------------------------------------
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp Lines 553-554 (patched) <https://reviews.apache.org/r/70945/#comment303135> Let's be specific: To be backwards compatible the lack of the field means we use an empty set, as before. src/java/src/org/apache/mesos/MesosSchedulerDriver.java Lines 260-265 (patched) <https://reviews.apache.org/r/70945/#comment303139> Why only this overload? What if the caller doesn't have a credential to pass? E.g. `implicitAcknowledgements` was added to both credential and non-credential constructors. (we should really have a builder style api here) - Benjamin Mahler On June 25, 2019, 4:28 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70945/ > ----------------------------------------------------------- > > (Updated June 25, 2019, 4:28 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9849 > https://issues.apache.org/jira/browse/MESOS-9849 > > > Repository: mesos > > > Description > ------- > > Added a constructor with a list of suppressed roles to Java V0 bindings. > > > Diffs > ----- > > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp > a21aca23cbef27b3c54bf1ae5834cbb457608130 > src/java/src/org/apache/mesos/MesosSchedulerDriver.java > 55ebc8772d9183286c908b4dba342109f28394f4 > > > Diff: https://reviews.apache.org/r/70945/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
