> On June 25, 2019, 7:21 p.m., Benjamin Mahler wrote: > > src/tests/master/update_framework_tests.cpp > > Lines 992-996 (patched) > > <https://reviews.apache.org/r/70895/diff/2/?file=2152137#file2152137line992> > > > > The framework update already occurred, and it may be in the allocator's > > queue, but that's fine. Why is this settling?
You are right, we don't need it now - I removed it from the patch. Is it true that the update will always be performed atomically in the allocator (i.e. no deferred calls will be initiated by the allocator to complete the update)? If this changes, adding the slave will race against the update... but most likely, we will have a whole bunch of other problems then;) - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70895/#review216126 ----------------------------------------------------------- On June 25, 2019, 3:30 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70895/ > ----------------------------------------------------------- > > (Updated June 25, 2019, 3:30 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9793 > https://issues.apache.org/jira/browse/MESOS-9793 > > > Repository: mesos > > > Description > ------- > > Added a test for supperssing roles via V0 updateFramework(). > > > Diffs > ----- > > src/tests/master/update_framework_tests.cpp > 0d466e286adfd829bbe72cff9202860f7fcb043f > > > Diff: https://reviews.apache.org/r/70895/diff/2/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkV0*SuppressedRoles" > --gtest_break_on_failure --gtest_repeat=1000` > > > Thanks, > > Andrei Sekretenko > >
