----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70951/ -----------------------------------------------------------
(Updated June 26, 2019, 9:50 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Addressed Ben's comments. Bugs: MESOS-9601 https://issues.apache.org/jira/browse/MESOS-9601 Repository: mesos Description ------- The new operations will mutate the `quota_configs` field in the registry to persist `QuotaConfigs` configured by the new `UPDATE_QUOTA` call as well as the legacy `SET_QUOTA` and `REMOVE_QUOTA` calls. The operation removes any entries in the legacy `quotas` field with the same role name. In addition, it also adds/removes the minimum capability `QUOTA_V2` accordingly: if `quota_configs` is empty the capability will be removed otherwise it will be added. This operation replaces the `REMOVE_QUOTA` operation. Also fixed affected tests. Diffs (updated) ----- src/master/master.cpp 826362d1a9ed034a49934b1810d6e1e6cffd90cd src/master/quota.hpp 959e312b861fc0b59519a9ab5cc51061b55b534c src/master/quota.cpp a7ee845d5916e859218b0168c7b682f77549aafc src/master/quota_handler.cpp 476e87eb67e07a2ec6c7b258667cf94ff9c4f8eb src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8 Diff: https://reviews.apache.org/r/70951/diff/3/ Changes: https://reviews.apache.org/r/70951/diff/2-3/ Testing ------- make check Thanks, Meng Zhu