----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70958/#review216179 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp Lines 2732 (patched) <https://reviews.apache.org/r/70958/#comment303241> Extranneous newline. - Greg Mann On June 26, 2019, 11:55 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70958/ > ----------------------------------------------------------- > > (Updated June 26, 2019, 11:55 p.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Bugs: MESOS-9862 > https://issues.apache.org/jira/browse/MESOS-9862 > > > Repository: mesos > > > Description > ------- > > With this patch the agent will now reject task launches while draining. > While we do not expect the master to send task launches to draining > agents it is still worthwhile to ensure no new tasks can be launched > while draining. This invariant simplifies e.g., the handling of drain > requests since we know that once the agent has entered a draining state > we only need to terminate existing tasks and no new tasks can appear. > > > Diffs > ----- > > src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e > > > Diff: https://reviews.apache.org/r/70958/diff/1/ > > > Testing > ------- > > `make check` > > tested as part of https://reviews.apache.org/r/70960/ > > > Thanks, > > Benjamin Bannier > >
