----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70834/#review216187 -----------------------------------------------------------
Ship it! src/slave/slave.cpp Lines 993 (patched) <https://reviews.apache.org/r/70834/#comment303262> Another case where it would be nice to have an builtin `operator<<` for `Option` like we already have for `Future`, https://github.com/apache/mesos/blob/1.8.0/3rdparty/libprocess/include/process/future.hpp#L1826. - Benjamin Bannier On June 25, 2019, 9:58 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70834/ > ----------------------------------------------------------- > > (Updated June 25, 2019, 9:58 p.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and > Joseph Wu. > > > Bugs: MESOS-9818 > https://issues.apache.org/jira/browse/MESOS-9818 > > > Repository: mesos > > > Description > ------- > > This patch adds a minimal handler to the agent for the > `DrainSlaveMessage`. This handler will later be extended > to implement the full functionality. > > > Diffs > ----- > > src/slave/paths.hpp ad768267e6a3c105eab4b36b05351d175d720eaf > src/slave/paths.cpp 1163c88eefd2a9e99b56817a3f515a23ee6e3903 > src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41 > src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e > > > Diff: https://reviews.apache.org/r/70834/diff/5/ > > > Testing > ------- > > Testing details at the end of this chain. > > > Thanks, > > Greg Mann > >
