----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70980/#review216306 -----------------------------------------------------------
Bad review! Reviews applied: [70980, 70966, 70965, 70979, 70978, 70977, 70976, 70975, 70974] Error: 2019-07-02 11:44:26 URL:https://reviews.apache.org/r/70965/diff/raw/ [3015/3015] -> "70965.patch" [1] error: patch failed: src/tests/master/update_framework_tests.cpp:72 error: src/tests/master/update_framework_tests.cpp: patch does not apply - Mesos Reviewbot On June 29, 2019, 12:56 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70980/ > ----------------------------------------------------------- > > (Updated June 29, 2019, 12:56 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9870 > https://issues.apache.org/jira/browse/MESOS-9870 > > > Repository: mesos > > > Description > ------- > > This is a refactoring of `updateFramework()` in the hierarchial > allocator which makes the symmetry between activating and > deactivating roles more visible. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 26aad6778f12b99bb87c846788d6b6d60f743d8a > > > Diff: https://reviews.apache.org/r/70980/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Sekretenko > >
