> On May 31, 2019, 4:24 a.m., James Peach wrote: > > You should add a test in this review. I'd probably do something reasonable > > simple, like launch a task and verify that the `NoNewPrivs` fiels in > > `/proc/$PID/status` is what you expect it to be. Take a look at > > `src/tests/containerizer/linux_filesystem_isolator_tests.cpp` for an > > example of how to construct the test by driving the containerizer directly. > > > > We also need to add feature and upgrade documentation, but if you want to > > do that in a later review, that's fine with me.
Yea later review sounds good to me. > On May 31, 2019, 4:24 a.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/linux/privs.hpp > > Lines 30 (patched) > > <https://reviews.apache.org/r/70757/diff/1/?file=2147135#file2147135line30> > > > > I did originally advise you to call this isolator something more open > > ended, because I had it in mind that we could extend this to toggle secbits > > as well. > > > > I've reconsidered and I think that I gave you bad advice. Let's check > > in with the other containerization folks, but I'm inclined to call this > > `linux/nnp` and leave it at that. > > > > Sorry for the back & forth. Yea scoping it down makes sense. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70757/#review215607 ----------------------------------------------------------- On July 3, 2019, 11:30 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70757/ > ----------------------------------------------------------- > > (Updated July 3, 2019, 11:30 p.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, Jie Yu, and James > Peach. > > > Bugs: MESOS-9770 > https://issues.apache.org/jira/browse/MESOS-9770 > > > Repository: mesos > > > Description > ------- > > This patch adds the isolation capability of flipping the > NO_NEW_PRIVILEGES bit for process control. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > 2d04f3c182a4274dda527a3da56c894c3c892a12 > src/CMakeLists.txt 1d4f541b73c07a307a8b61f217e0cfad5dc095e4 > src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 > src/slave/containerizer/mesos/containerizer.cpp > 043244841a73fa3f5f7119bc38f6d3a04be8990b > src/slave/containerizer/mesos/isolators/linux/nnp.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/linux/nnp.cpp PRE-CREATION > src/slave/containerizer/mesos/launch.cpp > b29ec556399a40aa662987a11a2b64e6a16de889 > src/tests/CMakeLists.txt 3ea8b4400ff3b00470aa147cb8f39f62802727e3 > src/tests/containerizer/linux_nnp_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70757/diff/2/ > > > Testing > ------- > > > Thanks, > > Jacob Janco > >
