> On July 3, 2019, 8:47 p.m., Benjamin Mahler wrote: > > How about: > > > > ``` > > Extracted suppression logic in allocator for use in update framework. > > > > This patch moves the logic of suppressing/unsuppressing a role set from > > the inside of 'suppressOffers()'/'reviveOffers()' into separate methods. > > Specifically, 'reviveOffers()' includes filter clearing logic that we > > don't want when unsuppressing roles during framework update. For > > 'supppressOffers()', we need the empty set == all roles semantics, but > > we don't want that in the suppression logic during framework update. > > > > Longer term, the empty set == all roles semantics could be done in > > the master and we won't need the extra function to provide empty set > > == all roles logic in the allocator. > > > > This is a prerequisite for using thes methods to fix > > 'updateFramework()' in a subsequent patch. > > ``` > > > > Note that I think we don't need the extra suppression function in the > > allocator, however we need to update the master to provide the empty set == > > all roles semantics (which is more of a protobuf API concern than something > > the allocator should know about).
Thanks! Looks much better. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70994/#review216358 ----------------------------------------------------------- On July 2, 2019, 7:10 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70994/ > ----------------------------------------------------------- > > (Updated July 2, 2019, 7:10 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9870 > https://issues.apache.org/jira/browse/MESOS-9870 > > > Repository: mesos > > > Description > ------- > > This patch moves the logic of suppressing/unsuppressing a role set from > the inside of 'suppressOffers()'/'reviveOffers()' into separate methods. > > This is a prerequisite for using this methods to fix updateFramework() > in the dependent patch. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 7e9765263f969a4499358579f1ee5bb1afb053da > src/master/allocator/mesos/hierarchical.cpp > 26aad6778f12b99bb87c846788d6b6d60f743d8a > > > Diff: https://reviews.apache.org/r/70994/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
