----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71022/#review216414 -----------------------------------------------------------
Patch looks great! Reviews applied: [71019, 71020, 71021, 71022] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 7, 2019, 10:12 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71022/ > ----------------------------------------------------------- > > (Updated July 7, 2019, 10:12 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8968 > https://issues.apache.org/jira/browse/MESOS-8968 > > > Repository: mesos > > > Description > ------- > > These tests reuse the existing tests for `SET_QUOTA` and > `REMOVE_QUOTA` calls. In general, `UPDATE_QUOTA` request > should fail where `SET_QUOTA` fails. When the existing > test expects `SET_QUOTA` call succeeds, we test the > `UPDATE_QUOTA` call by first remove the set quota and then > send the `UPDATE_QUOTA` request. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp 34a652029e31827f8d94bb66d408fbe3d121fd8f > > > Diff: https://reviews.apache.org/r/71022/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
