----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70960/#review216434 -----------------------------------------------------------
Patch looks great! Reviews applied: [70822, 70839, 70834, 70835, 70836, 70899, 70900, 70901, 70903, 70904, 70906, 70907, 70936, 70958, 70959, 70960] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 28, 2019, 2:27 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70960/ > ----------------------------------------------------------- > > (Updated June 28, 2019, 2:27 a.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Bugs: MESOS-9860 > https://issues.apache.org/jira/browse/MESOS-9860 > > > Repository: mesos > > > Description > ------- > > This patch adds a test which confirms that the agent leaves a draining > state on its own once all frameworks on the agent have no more pending > tasks and all their executors have neither launched or queued tasks. > > The test uses the fact that the agent rejects task launches while > draining. > > > Diffs > ----- > > src/tests/slave_tests.cpp 7ba2df9fef9966cd09e0af3f4ef3bb260b6167f6 > > > Diff: https://reviews.apache.org/r/70960/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
