----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71032/#review216466 -----------------------------------------------------------
Ship it! src/tests/role_tests.cpp Lines 596-597 (patched) <https://reviews.apache.org/r/71032/#comment303705> hmm, feels a bit inconsistent that resources still keep the zeros. - Meng Zhu On July 9, 2019, 6:20 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71032/ > ----------------------------------------------------------- > > (Updated July 9, 2019, 6:20 p.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-9871 > https://issues.apache.org/jira/browse/MESOS-9871 > > > Repository: mesos > > > Description > ------- > > This ensures that the various edge different states of resources > are correctly handled, see test comment for more details. > > > Diffs > ----- > > src/tests/role_tests.cpp bf5b3cba59d38eee41ed222d14bc8c928fcf2a79 > > > Diff: https://reviews.apache.org/r/71032/diff/2/ > > > Testing > ------- > > Ran 1000 times in repetition. > > > Thanks, > > Benjamin Mahler > >
