----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71033/#review216620 -----------------------------------------------------------
Fix it, then Ship it! src/Makefile.am Lines 1092 (patched) <https://reviews.apache.org/r/71033/#comment303834> This is missing the related CMake change. In src/CMakeLists.txts: ``` set(DOCKER_SRC docker/docker.cpp + docker/executor.cpp docker/spec.cpp) ``` src/Makefile.am Line 1812 (original), 1813 (patched) <https://reviews.apache.org/r/71033/#comment303833> This is missing the related CMake changes. * Delete src/docker/CMakeLists.txt * Add this to src/launcher/CMakeLists.txt: ``` # THE DOCKER EXECUTOR EXECUTABLE. ################################# add_executable(mesos-docker-executor docker_executor.cpp) target_link_libraries(mesos-docker-executor PRIVATE mesos) ``` - Joseph Wu On July 8, 2019, 11:22 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71033/ > ----------------------------------------------------------- > > (Updated July 8, 2019, 11:22 a.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu. > > > Bugs: MESOS-9853 > https://issues.apache.org/jira/browse/MESOS-9853 > > > Repository: mesos > > > Description > ------- > > This moves the declaration of the Docker executor into the > Docker executor header file and moves the code for the Docker > executor binary into a new launcher implementation file. > > This change will enable the Mesos executor driver > implementation to make use of the `DockerExecutor` symbol. > > > Diffs > ----- > > src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 > src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef > src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 > src/launcher/docker_executor.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/71033/diff/1/ > > > Testing > ------- > > Details at the end of this chain. > > > Thanks, > > Greg Mann > >
