----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70996/#review216636 -----------------------------------------------------------
Ship it! Ship It! - Greg Mann On July 15, 2019, 11:30 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70996/ > ----------------------------------------------------------- > > (Updated July 15, 2019, 11:30 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and > Vinod Kone. > > > Bugs: MESOS-9814 > https://issues.apache.org/jira/browse/MESOS-9814 > > > Repository: mesos > > > Description > ------- > > This fleshes out three master calls: > * DRAIN_AGENT > * DEACTIVATE_AGENT > * REACTIVATE_AGENT > > The master now stores a mapping of agent draining or deactivation > information. When an agent reconnects, this information is checked > before informing the allocator about the agent. > > This commit leaves out certain aspects of each endpoint's validation, > such as checking if draining agents are not in maintenance schedules. > > The DRAIN_AGENT call is not completely implemented here, because the > transition from DRAINING to DRAINED will be added in a separate commit. > > > Diffs > ----- > > src/master/http.cpp cd0f40cb7b966d6620e3fb49d4c08807185c9101 > src/master/master.hpp e8def83fe9bcee19772df9a9764852bc694c5247 > src/master/master.cpp 5247377c2e7e92b9843dd4c9d28f92ba679ad742 > > > Diff: https://reviews.apache.org/r/70996/diff/3/ > > > Testing > ------- > > TODO: At this point, there isn't anything exposed by the master which can be > used to check the results of these APIs. > > > Thanks, > > Joseph Wu > >
