----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70887/#review216641 -----------------------------------------------------------
src/common/future_tracker.hpp Lines 101-105 (patched) <https://reviews.apache.org/r/70887/#comment303843> probably we want to add some comments to explain these parameters. Other than `name`, another para confuses me a bit is `component`. In next patch, we have `containerizer` as component and `isolator::method` as name. How do we define component and name for the following case: ``` mesos_containerizer->provisioner->docker_store->local_puller->pull()``` - Gilbert Song On June 19, 2019, 7:49 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70887/ > ----------------------------------------------------------- > > (Updated June 19, 2019, 7:49 a.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, James Peach, Meng > Zhu, and Qian Zhang. > > > Bugs: MESOS-9837 > https://issues.apache.org/jira/browse/MESOS-9837 > > > Repository: mesos > > > Description > ------- > > This patch introduces a mechanism for tracking pending futures. > This feature allows detection of hanging operations, which get > stuck on a blocking operation or asynchronously. However, this > feature does not provide any mechanism for tracking pending > promises, because `Promise` objects might not be accessible in > various cases. Thereby, we introduce a new class that can be > used to track pending futures, so it might facilitate debugging > of stuck issues. > > > Diffs > ----- > > src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 > src/common/future_tracker.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70887/diff/4/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
