----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71120/#review216779 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On July 19, 2019, 3:42 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71120/ > ----------------------------------------------------------- > > (Updated July 19, 2019, 3:42 a.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9788 > https://issues.apache.org/jira/browse/MESOS-9788 > > > Repository: mesos > > > Description > ------- > > 1. Do not support specifying the size of /dev/shm when the IPC mode > is not `PRIVATE`. > 2. Do not support private IPC mode for debug containers. > > > Diffs > ----- > > docs/isolators/namespaces-ipc.md 4c978ec4995538b45fc5de6db199b6e3af6a2e99 > include/mesos/mesos.proto 075c110acb9977e67a87220cf97e7e325826b2af > include/mesos/v1/mesos.proto 0dcaee659764b26c548aba6827404a5577491db0 > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > 743d48d07cdb3729d871dcb1c74d5d841af5f53f > src/tests/containerizer/isolator_tests.cpp > 14feaed50d4e71e2dfaba21880cd67f53584366f > > > Diff: https://reviews.apache.org/r/71120/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >