> On July 26, 2019, 6:40 a.m., Chun-Hung Hsiao wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 846 (original), 846 (patched) > > <https://reviews.apache.org/r/71148/diff/1/?file=2157523#file2157523line846> > > > > How about using zero here, as described in `mesos.proto`? > > > > And since most tests require no reconciliation, maybe making zero the > > default in `setupResourceProviderConfig`?
Makes sense. This actually uncovered that this series was incorrectly handling the zero duration case. Fixed the issue you raised here and corrected the handling. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71148/#review216877 ----------------------------------------------------------- On July 29, 2019, 10:56 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71148/ > ----------------------------------------------------------- > > (Updated July 29, 2019, 10:56 a.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-9254 > https://issues.apache.org/jira/browse/MESOS-9254 > > > Repository: mesos > > > Description > ------- > > Explicitly disabled periodic reconciliation for some provider tests. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 69b59d48ceefebbb7accefe411c54ac5cecff1c3 > > > Diff: https://reviews.apache.org/r/71148/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
