----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71159/#review216913 -----------------------------------------------------------
Fix it, then Ship it! The test from the previous patch failed? src/tests/master_quota_tests.cpp Lines 347 (patched) <https://reviews.apache.org/r/71159/#comment304152> Avoid the hard check on the response body parsing correctly? src/tests/master_quota_tests.cpp Lines 405 (patched) <https://reviews.apache.org/r/71159/#comment304153> Ditto here - Benjamin Mahler On July 25, 2019, 1:55 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71159/ > ----------------------------------------------------------- > > (Updated July 25, 2019, 1:55 a.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-9598 and MESOS-9599 > https://issues.apache.org/jira/browse/MESOS-9598 > https://issues.apache.org/jira/browse/MESOS-9599 > > > Repository: mesos > > > Description > ------- > > Added quota configuration information (that includes both > guarantees and limits) in V1 GET_QUOTA call and V0 GET "/quota". > > To keep backwards compatibility, the infos field which only > includes the guarantees are continue to be filled. An additional > field configs was added. > > Also extended an existing test to cover the changes in > the endpoints. > > > Diffs > ----- > > src/master/quota_handler.cpp 15b02b08917201c824230d649fdae265957748af > src/tests/master_quota_tests.cpp 7745fb0a903c4dc5603c12049f224b3d45273a4b > > > Diff: https://reviews.apache.org/r/71159/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
