----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71186/#review216925 -----------------------------------------------------------
Ship it! 3rdparty/stout/tests/protobuf_tests.cpp Line 838 (original), 841 (patched) <https://reviews.apache.org/r/71186/#comment304158> // Test that the protobuf maps to the expected json. 3rdparty/stout/tests/protobuf_tests.cpp Lines 841-845 (original), 843-852 (patched) <https://reviews.apache.org/r/71186/#comment304157> This was a bit of a puzzling read, how about? ``` // Test that we can map the json back to the expected protobuf. Try<JSON::Value> json = JSON::parse(expected); ASSERT_SOME(json); Try<tests::MapMessage> protoFromJson = protobuf::parse<tests::MapMessage>(*json); ASSERT_SOME(protoFromJson); EXPECT_TRUE( google::protobuf::util::MessageDifferencer::Equals(message, *parseProto)); ``` - Benjamin Mahler On July 29, 2019, 9:54 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71186/ > ----------------------------------------------------------- > > (Updated July 29, 2019, 9:54 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9901 > https://issues.apache.org/jira/browse/MESOS-9901 > > > Repository: mesos > > > Description > ------- > > Improved a test for jsonify map fields mapping. > > > Diffs > ----- > > 3rdparty/stout/tests/protobuf_tests.cpp > 95cdc67cdab0aeef2ce18aa0c99bc2952c2b5dc5 > > > Diff: https://reviews.apache.org/r/71186/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
