> On July 30, 2019, 12:19 p.m., Greg Mann wrote: > > src/webui/app/agents/agent.html > > Line 64 (original), 64 (patched) > > <https://reviews.apache.org/r/71184/diff/1/?file=2158121#file2158121line64> > > > > Why "grace time" instead of "grace period"?
I am not a native speaker, but to me "period" would indicate an interval, while "time" denotes a point in time. Let's either keep this or use something else clearly distinguished from an interval (`max_grace_deadline_seconds`?). WDYT? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71184/#review216956 ----------------------------------------------------------- On July 30, 2019, 2:40 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71184/ > ----------------------------------------------------------- > > (Updated July 30, 2019, 2:40 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-9907 > https://issues.apache.org/jira/browse/MESOS-9907 > > > Repository: mesos > > > Description > ------- > > Added expected drain end time to webui's agent screen. > > > Diffs > ----- > > src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf > src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6 > > > Diff: https://reviews.apache.org/r/71184/diff/2/ > > > Testing > ------- > > * `make check` > * patched agent to not discard `drainConfig` and inspected screen for > `drained` agent run via `mesos-local` > > > Thanks, > > Benjamin Bannier > >
