> On July 26, 2019, 6:38 a.m., Chun-Hung Hsiao wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 331 (patched) > > <https://reviews.apache.org/r/71147/diff/1/?file=2157522#file2157522line332> > > > > I'm actually thinking about haveing a really short reconciliation > > interval for testing here, so certain tests won't wait for a long time. > > WDYT? > > > > Or, maybe we can inject proper reconciliation intervals only in the > > tests that checks for reconciliations.
This is exactly what is being done in the follow-up patch https://reviews.apache.org/r/71148/. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71147/#review216876 ----------------------------------------------------------- On July 29, 2019, 10:56 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71147/ > ----------------------------------------------------------- > > (Updated July 29, 2019, 10:56 a.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-9254 > https://issues.apache.org/jira/browse/MESOS-9254 > > > Repository: mesos > > > Description > ------- > > Update config factory to set resource provider reconciliation interval. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 69b59d48ceefebbb7accefe411c54ac5cecff1c3 > > > Diff: https://reviews.apache.org/r/71147/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
