----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71194/#review217058 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 342 (patched) <https://reviews.apache.org/r/71194/#comment304302> Use `at()`? src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 346 (patched) <https://reviews.apache.org/r/71194/#comment304307> There are three experessions `foreachpair` so if we break them apart, put each one a line? src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 347 (patched) <https://reviews.apache.org/r/71194/#comment304308> s/container volumes/persistent volumes/? src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 423 (patched) <https://reviews.apache.org/r/71194/#comment304310> Do we need to single out the overlay backend? Seems like we can just scan all backends? src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 424 (patched) <https://reviews.apache.org/r/71194/#comment304309> FWIW sandbox scanning predates the container run state, now it does look like at least sandboxes (or any paths that can be deduced from the container ID) would be covered given it's checkpointed pretty early: https://github.com/apache/mesos/blob/e1176c453d04a8ef8f53cf23928b5bbb09173d78/src/slave/containerizer/mesos/containerizer.cpp#L1547 but of course the emphemeral volumes are added later than that and there could be dirs with projectIDs set before `ephemeral_volumes` is persisted. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 517 (patched) <https://reviews.apache.org/r/71194/#comment304311> Same question: why don't we fail here? - Jiang Yan Xu On Aug. 1, 2019, 7:27 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71194/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2019, 7:27 p.m.) > > > Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-9900 > https://issues.apache.org/jira/browse/MESOS-9900 > > > Repository: mesos > > > Description > ------- > > Add support for labeling ephemeral volumes with the sandbox XFS > project ID. This makes changes to the container rootfs share the > same disk quota as the sandbox. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 646330c65b24aa28801ec99d7909db08a3e05c79 > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp > 362e02172d2fd8e6e241fb6f5689f569ba74a0d1 > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp > f2040cf36c601a13281a78ff844ebd41000a2d65 > > > Diff: https://reviews.apache.org/r/71194/diff/3/ > > > Testing > ------- > > sudo make check (Frdora 30) > > > Thanks, > > James Peach > >
