----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71247/#review217116 -----------------------------------------------------------
I think we also need to update `agent.md`, `operator-http-api.md` (the `GET_FLAGS` call), `upgrades.md` and `CHANGELOG` for this flag. src/slave/flags.hpp Lines 63 (patched) <https://reviews.apache.org/r/71247/#comment304379> I think we do not need `allow` here just like the other similar bool flag `switch_user`, maybe just `docker_volume_chown` which is also consistent with the flag above it (`docker_volume_checkpoint_dir`). - Qian Zhang On Aug. 8, 2019, 8:54 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71247/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2019, 8:54 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-9908 > https://issues.apache.org/jira/browse/MESOS-9908 > > > Repository: mesos > > > Description > ------- > > Added a new agent flag --allow_chown_docker_volume. > > > Diffs > ----- > > src/slave/flags.hpp 01834f41f2cd045cdb745e90d7f57fc2948ae024 > src/slave/flags.cpp 08ec20b30e7d82ab453c0b96c208ab1c1cc812db > > > Diff: https://reviews.apache.org/r/71247/diff/1/ > > > Testing > ------- > > make > > > Thanks, > > Gilbert Song > >
