----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71312/#review217298 -----------------------------------------------------------
Ship it! src/master/allocator/mesos/hierarchical.hpp Lines 191 (patched) <https://reviews.apache.org/r/71312/#comment304589> Consider making the test a friend? Or documenting that this one is only for testing? src/master/allocator/mesos/hierarchical.hpp Line 237 (original), 239 (patched) <https://reviews.apache.org/r/71312/#comment304590> Document that None is for testing only? - Benjamin Mahler On Aug. 19, 2019, 9:03 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71312/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2019, 9:03 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This makes the metric handler optional. This is mainly for > unit testing purpose. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 8be8dcee04e8fc5b97f730b2f058d14c81678788 > src/master/allocator/mesos/hierarchical.cpp > 580d35a3b71c1f7e851fa0504c6b9f037c05c378 > > > Diff: https://reviews.apache.org/r/71312/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
