> On Aug. 19, 2019, 4:12 p.m., Benjamin Mahler wrote: > > Thanks! > > > > We could probably unit test the `empty()` function (for each case), then > > for role tracking, we could use one case (e.g. weights) to test more cases. > > Specifically, right now we are only testing the case wehre removal walks > > all the way up to the root, but we're missing the case where it has to stop > > because an ancestor is !empty.
That would be somewhat whitebox testing. Will add more tests shortly. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71313/#review217306 ----------------------------------------------------------- On Aug. 19, 2019, 3:34 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71313/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2019, 3:34 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added a test for RoleTree for basic add and remove operations. > > > Diffs > ----- > > src/tests/sorter_tests.cpp fc33971758d99192dc2c1e4d78b41edd14eaa1fa > > > Diff: https://reviews.apache.org/r/71313/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
