----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71174/#review217339 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/cni/cni.cpp Lines 542-547 (original), 542-556 (patched) <https://reviews.apache.org/r/71174/#comment304633> We distinguish the top level container from nested container by has_executor_info and has_container_info. Please add comments because people may not know it if they don't check ContainerState proto. - Gilbert Song On July 29, 2019, 1:40 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71174/ > ----------------------------------------------------------- > > (Updated July 29, 2019, 1:40 a.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9909 > https://issues.apache.org/jira/browse/MESOS-9909 > > > Repository: mesos > > > Description > ------- > > Recovered network info for nested/standalone containers in CNI isolator. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > a60c96302a6cec90ecd0a0885b844fff8d37db71 > src/common/protobuf_utils.hpp 5d6a35d6e3bae35b83e87827724206f7c5dfb2d8 > src/common/protobuf_utils.cpp 7778e7f2475e9d6125d1c599715c91715f3654d3 > src/slave/containerizer/mesos/containerizer.cpp > a01edc8793a2eaa655f1729a01a01f1f61fbf7cb > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > f2989cf7a2161154bb7d9bf2112bee8dd3cc5cf5 > > > Diff: https://reviews.apache.org/r/71174/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
