----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71341/#review217364 -----------------------------------------------------------
Patch looks great! Reviews applied: [71339, 71340, 71341] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 21, 2019, 6:22 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71341/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2019, 6:22 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-9482 > https://issues.apache.org/jira/browse/MESOS-9482 > > > Repository: mesos > > > Description > ------- > > For some calls we expect resource providers to set provider IDs with the > calls. While the resource provider manager has always asserted that the > calls were correct we never validated this. > > With this patch we perform additional validation for calls taking a > `ResourceProviderInfo` into account. We add both unit tests for the > validation code and an integration test confirming that the validation > is actually triggered. > > > Diffs > ----- > > src/resource_provider/manager.cpp ceed1225b37d23998f523afcc2184dfaaad60636 > src/resource_provider/validation.cpp > df55b5efe3543c1dfd8441997302ab76fdd4bcc1 > src/tests/resource_provider_manager_tests.cpp > bcf6a03aa5d4931feff0299c811faa216efd95b6 > src/tests/resource_provider_validation_tests.cpp > a9989412ae30bd8244be808fc88fbe70f47d6ad9 > > > Diff: https://reviews.apache.org/r/71341/diff/1/ > > > Testing > ------- > > `ninja check` > > > Thanks, > > Benjamin Bannier > >
