----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71333/#review217369 -----------------------------------------------------------
Ship it! Should probably clarify that this doesn't eliminate a copy during sort? Only during client add / remove? - Benjamin Mahler On Aug. 21, 2019, 12:59 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71333/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2019, 12:59 a.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Avoided copying the clientPath in the sorter. > > > Diffs > ----- > > src/master/allocator/mesos/sorter/drf/sorter.hpp > 537086039fd804453ea8c682cda775d8fdff038f > src/master/allocator/mesos/sorter/random/sorter.hpp > f18b014ed15ff8906fbdbd3248becefde896651c > > > Diff: https://reviews.apache.org/r/71333/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >