----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71353/#review217387 -----------------------------------------------------------
Fix it, then Ship it! src/common/resources.cpp Line 1324 (original), 1298 (patched) <https://reviews.apache.org/r/71353/#comment304679> Mentioned the assumption of the only disk resource might be indivisable? ditto below. - Meng Zhu On Aug. 22, 2019, 3:34 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71353/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2019, 3:34 p.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-9806 > https://issues.apache.org/jira/browse/MESOS-9806 > > > Repository: mesos > > > Description > ------- > > Master: > *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Made 3500 allocations in 30.37 secs > Made 0 allocation in 27.05 secs > > Master + this patch: > *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Made 3500 allocations in 24.15 secs > Made 0 allocation in 20.48 secs > > > Diffs > ----- > > include/mesos/resources.hpp a6a052ba51e13e2804eca846f08605e7f0714cfd > include/mesos/v1/resources.hpp e43d1fba69771405f4575cf675d6f0cd13c2c7c9 > src/common/resources.cpp fc7e86ba5eee3deb953d85065a1192374910c5e5 > src/v1/resources.cpp 88da0a185bd54e7053a221fe0b3255f3c514ac60 > > > Diff: https://reviews.apache.org/r/71353/diff/1/ > > > Testing > ------- > > > Thanks, > > Benjamin Mahler > >