> On Aug. 25, 2019, 11:09 p.m., Benjamin Mahler wrote: > > site/Gemfile > > Lines 3-6 (original), 3-6 (patched) > > <https://reviews.apache.org/r/71368/diff/1/?file=2162893#file2162893line3> > > > > Hm.. what's this syntax expressing? Ditto above.
This means "any package version with version 3.x.x", see https://bundler.io/v1.5/gemfile.html#gemfiles. We additionally version-control `Gemfile.lock`, so there is no strong need to bind specific versions in this case here. We want to exclude middleman from 4.x.x upwards though as it is incompatible. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71368/#review217429 ----------------------------------------------------------- On Aug. 25, 2019, 11:20 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71368/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2019, 11:20 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Updated site's middleman versions. > > > Diffs > ----- > > site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 > site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 > > > Diff: https://reviews.apache.org/r/71368/diff/1/ > > > Testing > ------- > > Site still generates. > > > Thanks, > > Benjamin Bannier > >
