----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71376/#review217473 -----------------------------------------------------------
Patch looks great! Reviews applied: [71376] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 27, 2019, 1:34 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71376/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2019, 1:34 p.m.) > > > Review request for mesos, Greg Mann and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > Previously, the future could be satisfied to the caller while > the dispatch back into the master for _apply is not fired (e.g. > if the thread running the allocator gets stuck). This could lead > to strange behavior and it's better to just avoid this race. > > > Diffs > ----- > > src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b > > > Diff: https://reviews.apache.org/r/71376/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
