----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71398/#review217498 -----------------------------------------------------------
Thanks for doing this! src/master/allocator/mesos/hierarchical.hpp Line 284 (original), 284 (patched) <https://reviews.apache.org/r/71398/#comment304752> Currently this should just be offered, i.e all call sites are just for offered ``` offered(const Resources& offered) ``` I guess later when we start to track allocated, we can just simply use the call, we will want to differentiate between offered and allocated anyway. Also, I think we can go without the `track` here. ditto below. - Meng Zhu On Aug. 29, 2019, 4:32 a.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71398/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2019, 4:32 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9949 > https://issues.apache.org/jira/browse/MESOS-9949 > > > Repository: mesos > > > Description > ------- > > Renamed allocated into offeredOrAllocated throughout allocator::Slave. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 65d103ea18b91adbdde3b0eb85113a1c0f4d990c > src/master/allocator/mesos/hierarchical.cpp > dd73d5b46c95ac7827d39ed93e0da097f4e8937a > > > Diff: https://reviews.apache.org/r/71398/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
