----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71400/#review217500 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/mesos/hierarchical.cpp Line 2104 (original), 2104 (patched) <https://reviews.apache.org/r/71400/#comment304759> "guaranteesAllocation" and "additionalScalarAllocation" and etc should ideally also be renamed. How about: `guaranteesAllocation` --> `guaranteesToOffer` `additionalScalarAllocation` --> `additionalScalars` - Meng Zhu On Aug. 29, 2019, 4:33 a.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71400/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2019, 4:33 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9949 > https://issues.apache.org/jira/browse/MESOS-9949 > > > Repository: mesos > > > Description > ------- > > Renamed `toAllocate` into `toOffer` in `HierarchialAllocatorProcess`. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > dd73d5b46c95ac7827d39ed93e0da097f4e8937a > > > Diff: https://reviews.apache.org/r/71400/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
