----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71410/#review217509 -----------------------------------------------------------
src/tests/mesos.hpp Lines 310-312 (patched) <https://reviews.apache.org/r/71410/#comment304764> Do we really need these three as arguments of `startSlave()`? I.e. why not set them via `SlaveBuilder`'s methods? My impression was that tests which use more than one slave tend to use the same master detector for all slaves (I might be totally wrong here, though). - Andrei Sekretenko On Aug. 29, 2019, 6:03 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71410/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2019, 6:03 p.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, > Gilbert Song, Greg Mann, James Peach, Joseph Wu, Meng Zhu, Qian Zhang, and > Till Toenshoff. > > > Bugs: MESOS-9914 > https://issues.apache.org/jira/browse/MESOS-9914 > > > Repository: mesos > > > Description > ------- > > This patch introduces a new builder class which should be used > instead of overloaded `MesosTest::StartSlave`. It's a preferred > way of creating and starting an instance of `cluster::Slave` in tests, > since underlying `cluster::Slave::create` accepts a long list of > optional arguments, which might be extended in the future. > > > Diffs > ----- > > src/tests/mesos.hpp 25359a24955fbe6413b3354aabf444818b58cb76 > src/tests/mesos.cpp 0396ce78b13e76cfe2596f0f92ddf9dcccc82fca > > > Diff: https://reviews.apache.org/r/71410/diff/1/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
