> On Aug. 30, 2019, 12:28 a.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 780-781 (original), 779-780 (patched) > > <https://reviews.apache.org/r/71399/diff/1/?file=2163097#file2163097line781> > > > > Same as the previous patch, should this just be `trackOffered`? Ditto > > for untrack
No, definitely not. Unlike similar `Slave`'s method from the previous patch, this one is also called in various resovery scenarios. In those cases some of the resources might be actually used by task/executor. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71399/#review217499 ----------------------------------------------------------- On Aug. 29, 2019, 11:33 a.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71399/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2019, 11:33 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9949 > https://issues.apache.org/jira/browse/MESOS-9949 > > > Repository: mesos > > > Description > ------- > > Renamed allocated -> offeredOrAllocated in HierarchialAllocatorProcess. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 65d103ea18b91adbdde3b0eb85113a1c0f4d990c > src/master/allocator/mesos/hierarchical.cpp > dd73d5b46c95ac7827d39ed93e0da097f4e8937a > src/master/allocator/mesos/metrics.cpp > f8465bef90815827c97ac2886d00c03a333f4df3 > > > Diff: https://reviews.apache.org/r/71399/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
