----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71391/#review217529 -----------------------------------------------------------
Fix it, then Ship it! support/snapshot.sh Line 40 (original), 41-45 (patched) <https://reviews.apache.org/r/71391/#comment304786> I am not a big fan of duplicating that complicated substitution around. What do you think about introducing a oneline helper function, e.g., ``` SED_I() { [[ "$OSTYPE" == "darwin"* ]] && sed -i '' $@ || sed -i $@; } SED_I "s/[mesos], [.*]/[mesos], [${TAG}]/" configure.ac ``` - Benjamin Bannier On Aug. 28, 2019, 6:38 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71391/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2019, 6:38 p.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Bugs: MESOS-9955 > https://issues.apache.org/jira/browse/MESOS-9955 > > > Repository: mesos > > > Description > ------- > > Fixed sed arg to work on Linux and OSX. > > > Diffs > ----- > > support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 > > > Diff: https://reviews.apache.org/r/71391/diff/1/ > > > Testing > ------- > > https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console > > > Thanks, > > Vinod Kone > >
